belliottsmith commented on code in PR #203:
URL: https://github.com/apache/cassandra-accord/pull/203#discussion_r2141158794
##########
accord-core/src/main/java/accord/coordinate/CoordinatePreAccept.java:
##########
@@ -142,7 +142,7 @@ void onNewEpochTopologyMismatch(TopologyMismatch mismatch)
proposeInvalidate(node, node.uniqueTimestamp(Ballot::fromValues),
txnId, route.homeKey(), (outcome, failure) -> {
if (failure != null)
mismatch.addSuppressed(failure);
- setFailure(mismatch);
+ callback.accept(null, mismatch);
Review Comment:
> If this change actually matters it implies that it was called after
isDone == true
I think I answered this already? to quote: "It is a callback ... that occurs
_after isDone is already set_."
That is, it occurs after `isDone == true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
