yifan-c commented on code in PR #233:
URL: https://github.com/apache/cassandra-sidecar/pull/233#discussion_r2178524845
##########
client/src/testFixtures/java/org/apache/cassandra/sidecar/client/SidecarClientTest.java:
##########
@@ -1811,6 +1816,90 @@ void testNodeUpdateNative() throws Exception
});
}
+ @Test
+ public void testLiveMigrationListInstanceFiles() throws
ExecutionException, InterruptedException, JsonProcessingException
Review Comment:
nit: please omit `public`, since it is unnecessary for the test.
##########
client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java:
##########
@@ -890,6 +894,38 @@ public <T> CompletableFuture<T>
executeRequestAsync(RequestContext context)
return executor.executeRequestAsync(context);
}
+ /**
+ * Gets list of files available at a Cassandra Instance using Sidecar
during Live Migration.
+ *
+ * @param instance Sidecar instance where the request will be executed
+ * @return a CompletableFuture representing the completion of the operation
+ */
+ public CompletableFuture<InstanceFilesListResponse>
liveMigrationListInstanceFilesAsync(SidecarInstance instance)
+ {
+ return
executor.executeRequestAsync(requestBuilder().singleInstanceSelectionPolicy(instance)
+ .request(new
LiveMigrationListInstanceFilesRequest())
+ .build());
+ }
+
+
+ /**
+ * Downloads requested file {@code reqPath} to the destination file
provided with param {@code targetFile}
+ * during Live Migration.
+ *
+ * @param instance the instance where the request will be executed
+ * @param reqPath instance file path to copy
+ * @param targetFilePath destination file path to save file coming from
remote
+ * @return a CompletableFuture representing the completion of the operation
+ */
+ public CompletableFuture<Boolean>
liveMigrationStreamFileAsync(SidecarInstance instance, String reqPath, String
targetFilePath)
Review Comment:
just curious, the boolean here can only be `true`, making it effectively the
same as `CompletableFuture<Void>`, right? Then, you can remove the
transformation at line926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
