ifesdjeen commented on code in PR #4227:
URL: https://github.com/apache/cassandra/pull/4227#discussion_r2192507000


##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -243,18 +243,23 @@ public synchronized static void startup(NodeId tcmId)
         }
         instance = as;
 
-        replayJournal(as);
+        // If we hit an error during journal replay, we need to mark ourselves 
unsafe to read, perform full data repair,
+        // and trigger RX before we can continue serving traffic
+        if (replayJournal(as) && 
ClusterMetadata.current().directory.allJoinedEndpoints().size() > 1)

Review Comment:
   Oh, we definitely need that in order to succeed. Here, I am just checking 
for whether or not we are in the single node cluster, in which case rebootstrap 
will simply not work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to