dcapwell commented on code in PR #4257:
URL: https://github.com/apache/cassandra/pull/4257#discussion_r2211255158
##########
src/java/org/apache/cassandra/index/accord/RouteJournalIndex.java:
##########
@@ -414,19 +412,49 @@ else if (e.column() ==
AccordJournalTable.SyntheticColumn.store_id.metadata && e
{
storeId = Int32Type.instance.compose(e.getIndexValue());
}
+ else if (e.column() ==
AccordJournalTable.SyntheticColumn.txn_id.metadata)
+ {
+ switch (e.operator())
+ {
+ case GT:
+ minTimestamp =
CommandSerializers.timestamp.deserialize(e.getIndexValue());
+ break;
+ case GTE:
+ minTimestamp =
CommandSerializers.timestamp.deserialize(e.getIndexValue());
+ break;
+ case LT:
+ maxTimestamp =
CommandSerializers.timestamp.deserialize(e.getIndexValue());
+ break;
+ case LTE:
+ maxTimestamp =
CommandSerializers.timestamp.deserialize(e.getIndexValue());
+ break;
+ default:
+ return null;
+ }
+ }
else
{
- throw new IllegalArgumentException("Unexpected expression: " +
e.toCQLString());
+ String cqlString;
+ try
+ {
+ cqlString = e.toCQLString();
Review Comment:
this failed when touching the new column, so made it defensive...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
