ifesdjeen commented on code in PR #225:
URL: https://github.com/apache/cassandra-accord/pull/225#discussion_r2216023231


##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -310,6 +309,8 @@ public AsyncResult<?> persist(DurableBefore addValue, 
DurableBefore newValue)
                 Invariants.require(addValue.maxEpoch() <= epoch());
                 return wrap.persist(addValue, newValue);
             }
+
+            @Override public boolean shouldPersist(DurableBefore addValue, 
DurableBefore newValue) { return wrap.shouldPersist(addValue, newValue); }

Review Comment:
   re-did the patch, changed it so that we use `shouldPersist` instead of 
abstract class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to