blambov commented on PR #4245: URL: https://github.com/apache/cassandra/pull/4245#issuecomment-3095360093
Oops, this is an error (and I've been looking at [datastax/cassandra/main where it is corrected](https://github.com/datastax/cassandra/blob/main/src/java/org/apache/cassandra/db/memtable/ShardBoundaries.java#L73)). We have end-inclusive ranges everywhere in the code, and it is very likely we are making some decisions slightly wrong because of this, including making on-disk and memtable shards slightly misaligned. AFAIU these methods are only used by the memtable and SAI's memtable index. If this is indeed so, there should be no permanent effect of this error, and we should be okay to fix it without causing any unintended effects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
