belliottsmith commented on code in PR #219:
URL: https://github.com/apache/cassandra-accord/pull/219#discussion_r2227874611
##########
accord-core/src/main/java/accord/coordinate/CoordinateSyncPoint.java:
##########
@@ -168,9 +167,8 @@ void onPreAccepted(Topologies topologies, Timestamp
executeAt, SortedListMap<Nod
if (txnId.is(ExclusiveSyncPoint) && txnId.epoch() ==
executeAt.epoch())
withFlags = txnId.addFlag(HLC_BOUND);
Deps deps = Deps.merge(oks.valuesAsNullableList(),
oks.domainSize(), List::get, ok -> ok.deps);
- if (tracker.hasFastPathAccepted())
- adapter.execute(node, executor, topologies, route,
Ballot.ZERO, FAST, CoordinationFlags.none(), txnId, txn, withFlags, deps, deps,
callback);
Review Comment:
It isn't possible for a sync point to take the fast path. It was a relic of
inclusive sync points that have been removed for various reasons. I think
there's some other vestiges, but this one intersected this change.
##########
accord-core/src/main/java/accord/coordinate/CoordinateTransaction.java:
##########
@@ -128,8 +129,8 @@ void onPreAccepted(Topologies topologies, Timestamp
executeAt, SortedListMap<Nod
// note: we merge all Deps regardless of witnessedAt. While we
only need fast path votes,
// we must include Deps from fast path votes from earlier
epochs that may have witnessed later transactions
// TODO (desired): we might mask some bugs by merging more
responses than we strictly need, so optimise this to optionally merge minimal
deps
+ node.agent().coordinatorEvents().onPreAccepted(txnId, deps,
true);
Review Comment:
Sure, I can add an enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
