smiklosovic commented on code in PR #4207:
URL: https://github.com/apache/cassandra/pull/4207#discussion_r2228649087
##########
src/java/org/apache/cassandra/db/commitlog/CommitLogReader.java:
##########
@@ -120,14 +120,24 @@ static List<File> filterCommitLogFiles(File[] toFilter)
/**
* Reads all passed in files with minPosition, no start, and no mutation
limit.
*/
- public void readAllFiles(CommitLogReadHandler handler, File[] files,
CommitLogPosition minPosition) throws IOException
- {
+ public void readAllFiles(CommitLogReadHandler handler, File[] files,
CommitLogPosition minPosition) throws IOException {
List<File> filteredLogs = filterCommitLogFiles(files);
int i = 0;
- for (File file: filteredLogs)
- {
+ for (File file : filteredLogs) {
i++;
- readCommitLogSegment(handler, file, minPosition, ALL_MUTATIONS, i
== filteredLogs.size());
+ boolean success = false;
Review Comment:
what do you need `success` for? If you went without having `success`, then
you would do `logger.info` call in `catch` block.
Also the way it is coded right now is that `handler.handleError` in catch
block might throw RuntimeException you are not catching nor acting upon
anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
