smiklosovic commented on PR #4226: URL: https://github.com/apache/cassandra/pull/4226#issuecomment-3126278251
@michaelsembwever I am trying to make sense of your last question > and shouldn't cassandra-env.sh be honouring the same server/client different jvm setup logic ? (it's not like it is non-nonsensical, it is just me not understanding it completely). How it seems to work for now is that if we have bin/cassandra, that will source cassandra.in.sh where a user have a chance to specify flag to JVM manually, and then these properties are taken and processed in cassandra.in.sh which is reacting on them. cassandra-env.sh seems to be only used in bin/cassandra (or, at least, it should be, as we see in this patch that we are sourcing it just because of a need to have JMX_PORT which might be bypassed by raw parsing of that script hence skipping sourcing altogether), then it is sourced in "bin/debug-cql" and "bin/jmh" (which used only in tests which is ... surprising and questionable but not a complete show stopper.). For debug-cql, I am not completely sure what we are trying to achieve by sourcing cassandra-env.sh either. For tools and rest of commands, cassandra-env.sh is not source and it is questionable if it should be. Check Dmitry's comment here: (1) (1) https://issues.apache.org/jira/browse/CASSANDRA-20745?focusedCommentId=17993028&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17993028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
