maedhroz commented on code in PR #4290:
URL: https://github.com/apache/cassandra/pull/4290#discussion_r2264374243
##########
src/java/org/apache/cassandra/utils/ByteBufferUtil.java:
##########
@@ -955,6 +955,18 @@ public static boolean contains(ByteBuffer buffer,
ByteBuffer subBuffer)
}
return false;
}
+ /**
+ * Check is the given buffer matches with the second buffer
+ *
+ * @param buffer1 The first buffer
+ * @param buffer2 The second buffer.
+ *
+ * @return true if both the buffers are equal, false otherwise.
+ */
+ public static boolean matches(ByteBuffer buffer1, ByteBuffer buffer2)
+ {
+ return buffer1.equals(buffer2);
+ }
Review Comment:
nit: I'd probably just inline this in `Expression` rather than having a
one-line utility method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
