belliottsmith commented on code in PR #238:
URL: https://github.com/apache/cassandra-accord/pull/238#discussion_r2265252934
##########
accord-core/src/main/java/accord/coordinate/FetchData.java:
##########
@@ -90,6 +90,13 @@ public FetchRequest(SequentialAsyncExecutor executor, Known
fetch, TxnId txnId,
this.reportTo = reportTo;
this.tracing = tracing;
}
+
+ @Override
+ public void accept(FetchResult success, Throwable fail)
+ {
+ if (fail != null && tracing != null) tracing.trace(null, "Failed
fetch: %s", Tracing.format(fail));
Review Comment:
I introduced wrap for this purpose, but this avoids an allocation. I left
wrap for future use cases (by which I mean when we have time to clean up other
call sites).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
