pkolaczk commented on code in PR #281:
URL: https://github.com/apache/cassandra-dtest/pull/281#discussion_r2269254210


##########
cqlsh_tests/test_cqlsh.py:
##########
@@ -599,7 +599,7 @@ def test_unicode_invalid_request_error(self):
             err = node1.run_cqlsh(cmds=cmd, cqlsh_options=options).stderr
 
         if self.cluster.version() >= LooseVersion('4.0'):
-            assert "Keyspace name must not be empty, more than 48 characters 
long, or contain non-alphanumeric-underscore characters (got 'ä')" in err
+            assert 'Keyspace name must not be empty or not contain 
non-alphanumeric-underscore characters (got "ä")' in err

Review Comment:
   Too many "not"?
   I'm not a native speaker, but this parses to me like:
   
   `Keyspace name must not: (be empty) or (not contain 
non-alphanumeric-underscore characters) (got "ä")`
   
   So for the second case it reduces to:
   `Keyspace name must not not contain non-alphanumeric-underscore characters 
(got "ä")`
   
   I think that "not" before "contain" is unneeded.
   It was correct before.
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to