k-rus commented on PR #4038: URL: https://github.com/apache/cassandra/pull/4038#issuecomment-3209687368
> I ported this patch to 5.0, see #4325. It failed a test on the error message for keyspace of `null` when called for create table, so I adjusted `validateKeyspaceName` to not change the exception message. This situation cannot happen on `trunk`, still I ported the change back in [0f7b756](https://github.com/apache/cassandra/commit/0f7b756f4b9c6d59e22cf78b3d9d8ba20b2e890a) However, it cannot be tested. > > @pkolaczk @netudima @Maxwell-Guo Do you want to review the commit and re-review the PR? Actually I found another bug in this implementation. `ire` doesn't throw, so I need to add throw. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
