dcapwell commented on code in PR #4328:
URL: https://github.com/apache/cassandra/pull/4328#discussion_r2292195349
##########
src/java/org/apache/cassandra/cql3/statements/CQL3CasRequest.java:
##########
@@ -558,15 +558,13 @@ private List<TxnWrite.Fragment>
createWriteFragments(ClientState state)
// see CASSANDRA-18337
ModificationStatement modification = update.stmt.forTxn();
QueryOptions options = update.options;
- TxnWrite.Fragment fragment =
modification.getTxnWriteFragment(idx++, state, options, partitionKey);
- fragments.add(fragment);
+ fragments.addAll(modification.getTxnWriteFragment(idx++, state,
options, partitionKey));
Review Comment:
added
`org.apache.cassandra.distributed.test.accord.AccordCQLTestBase#emptyCas` to
check if this assumption ever gets changed. Its currently blocked so this
can't ever be empty, but if that restriction changes this test will fail and
the docs should tell the author what to look at.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
