absurdfarce commented on code in PR #2052:
URL:
https://github.com/apache/cassandra-java-driver/pull/2052#discussion_r2292851705
##########
core/src/main/java/com/datastax/dse/driver/internal/core/data/geometry/DefaultGeometry.java:
##########
@@ -176,7 +176,7 @@ public boolean equals(Object o) {
return false;
}
DefaultGeometry that = (DefaultGeometry) o;
- return this.getOgcGeometry().equals(that.getOgcGeometry());
+ return this.getOgcGeometry().equals((Object) that.getOgcGeometry());
Review Comment:
ESRI 1.2.1 used to test equality by a literal comparison across fields of
OGCGeometry types. As of 2.2.4 this was changed to two distinct comparisons:
equals(Object) (the standard Java equality op) and equals(OGCGeometry). The
later was subsequently deprecated and moved to an Equals(OGCGeometry) method.
The code above was calling the (now deprecated) method.
More info can be found on a thread starting from the relevant
esri-geometry-api [PR](https://github.com/Esri/geometry-api-java/pull/143)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
