smiklosovic commented on code in PR #4340:
URL: https://github.com/apache/cassandra/pull/4340#discussion_r2301174290
##########
src/java/org/apache/cassandra/db/virtual/SettingsTable.java:
##########
@@ -89,13 +90,34 @@ public DataSet data()
@VisibleForTesting
String getValue(Property prop)
{
+ Credential maybeCredential = prop.getAnnotation(Credential.class);
Review Comment:
I tried to do this on a deeper level but that is not simple / does not seem
to be possible. We are "flattening" and properties are created on the fly
(`AndThen` property etc.) and annotations are placed on a _field_. I do not
think we can easily retrofit it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
