mrktsm commented on code in PR #4316:
URL: https://github.com/apache/cassandra/pull/4316#discussion_r2335192131
##########
src/java/org/apache/cassandra/db/virtual/SettingsTable.java:
##########
@@ -115,12 +119,31 @@ String getValue(Property prop)
map.put(entry.getKey(), entry.getValue());
}
- return map.toString();
+ return tryConstructJson(map);
}
return value.toString();
}
+ private String tryConstructJson(Object o)
+ {
+ if
(CassandraRelevantProperties.VIRTUAL_TABLE_COMPLEX_SETTINGS_FORMAT_JSON.getBoolean())
Review Comment:
Good point. Fixed the boolean resolution - moved it to the constructor like
you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
