jasonk000 commented on PR #2025: URL: https://github.com/apache/cassandra-java-driver/pull/2025#issuecomment-3275932012
> I suppose since this PR added some logging that might explain why hadn't seen this before? Although I do see there was logging previously in some places. Yeah, good question. The existing released code in 4.19.0 DOES contain a similar issue, however it is in a different piece of the code that is less likely to be triggered. In the old code we have [one](https://github.com/apache/cassandra-java-driver/blob/4.19.0/core/src/main/java/com/datastax/oss/driver/internal/core/session/throttling/ConcurrencyLimitingRequestThrottler.java#L195) spot that can trigger it. If the logger throws here, then the `concurrentRequests` would never be decremented. If this happens enough, then you will eventually consume all slots. In the new code we have [one](https://github.com/jasonk000/cassandra-java-driver/blob/fda2d0eb171a47c9861a8f44c32af27ba450e4fb/core/src/main/java/com/datastax/oss/driver/internal/core/session/throttling/ConcurrencyLimitingRequestThrottler.java#L99-L102) [two](https://github.com/jasonk000/cassandra-java-driver/blob/fda2d0eb171a47c9861a8f44c32af27ba450e4fb/core/src/main/java/com/datastax/oss/driver/internal/core/session/throttling/ConcurrencyLimitingRequestThrottler.java#L113-L114) [three](https://github.com/jasonk000/cassandra-java-driver/blob/fda2d0eb171a47c9861a8f44c32af27ba450e4fb/core/src/main/java/com/datastax/oss/driver/internal/core/session/throttling/ConcurrencyLimitingRequestThrottler.java#L127-L128). You can see they are more directly in the line of fire and much easier to trigger. You can see [in this commit to fix it](https://github.com/apache/cassandra-java-driver/commit/b3cdb43de6a791e76f13a0737561d11ce2e068a5) that we only have to enforce it in a few specific areas. ---- > .. recursion .. > Is that a new issue or something that would have previously existed prior to this PR You are correct, this is a new issue/fix and can probably be considered separate. Maybe I should put together a separate PR just for the smaller logger handler changes and deal with the loop/recursion one separate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
