jaydeepkumar1984 commented on code in PR #4126:
URL: https://github.com/apache/cassandra/pull/4126#discussion_r2338082338
##########
src/java/org/apache/cassandra/repair/autorepair/AutoRepair.java:
##########
@@ -484,8 +498,8 @@ private void cleanupAndUpdateStats(RepairTurn turn,
AutoRepairConfig.RepairType
TimeUnit.SECONDS.toDays(repairState.getClusterRepairTimeInSec()));
}
repairState.setLastRepairTime(timeFunc.get());
-
repairState.setRepairInProgress(false);
Review Comment:
Similar to other metrics, we don't reset here until the next cycle, so I
guess we should not reset these newly added metrics too.
##########
src/java/org/apache/cassandra/repair/autorepair/FixedSplitTokenRangeSplitter.java:
##########
@@ -117,20 +107,24 @@ private KeyspaceRepairAssignments
getRepairAssignmentsForKeyspace(boolean primar
if (byKeyspace)
{
+ long totalBytes = repairPlan.getEstimatedBytes();
+ long bytesPerRange = Math.max(1, totalBytes / splitsPerRange);
Review Comment:
Yeah, added a comment to clarify this here and also inside metrics.adoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
