netudima commented on code in PR #4356: URL: https://github.com/apache/cassandra/pull/4356#discussion_r2369944693
########## test/unit/org/apache/cassandra/db/virtual/ExceptionsTableTest.java: ########## @@ -0,0 +1,295 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.virtual; + +import java.util.LinkedHashMap; +import java.util.List; +import java.util.concurrent.TimeUnit; +import java.util.function.Consumer; + +import com.google.common.collect.ImmutableList; +import com.google.common.util.concurrent.Uninterruptibles; +import org.junit.Test; + +import org.apache.cassandra.cql3.CQLTester; +import org.apache.cassandra.cql3.UntypedResultSet; +import org.apache.cassandra.db.marshal.UTF8Type; +import org.apache.cassandra.utils.JVMStabilityInspector; + +import static java.lang.String.format; +import static java.lang.Thread.currentThread; +import static java.util.stream.Collectors.toList; +import static org.apache.cassandra.db.virtual.ExceptionsTable.EXCEPTIONS_TABLE_NAME; +import static org.apache.cassandra.utils.logging.AbstractVirtualTableAppender.getVirtualTable; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; + +public class ExceptionsTableTest extends CQLTester +{ + private static final String KS_NAME = "vts"; + + @Test + public void testExceptionInterceptionWhileVirtualTableIsNotRegistered() + { + doWithVTable(100, table -> + { + JVMStabilityInspector.uncaughtException(currentThread(), new MyUncaughtException("my exception")); + JVMStabilityInspector.uncaughtException(currentThread(), new MyUncaughtException2("my exception2")); + + // register after treating exception, so it goes to pre-initialisation buffer first + VirtualKeyspaceRegistry.instance.register(new VirtualKeyspace(KS_NAME, ImmutableList.of(table))); + + // we have buffer populated with exceptions from time vtable was not initialized yet + assertEquals(2, ExceptionsTable.preInitialisationBuffer.size()); + + // flush buffer and populate table internally + table.flush(); + + assertTrue(ExceptionsTable.preInitialisationBuffer.isEmpty()); + + ExceptionsTable.BoundedMap buffer = table.buffer; + assertEquals(2, buffer.size()); + }); + } + + @Test + public void testExceptionsTableWhileVirtualTableIsRegistered() + { + doWithVTable(100, table -> + { + // register before treating exception to avoid pre-initialisation buffer + VirtualKeyspaceRegistry.instance.register(new VirtualKeyspace(KS_NAME, ImmutableList.of(table))); + ExceptionsTable.INSTANCE = getVirtualTable(ExceptionsTable.class, KS_NAME, EXCEPTIONS_TABLE_NAME); + + JVMStabilityInspector.uncaughtException(currentThread(), new MyUncaughtException("my exception")); + JVMStabilityInspector.uncaughtException(currentThread(), new MyUncaughtException2("my exception2")); + + assertTrue(ExceptionsTable.preInitialisationBuffer.isEmpty()); + ExceptionsTable.BoundedMap buffer = table.buffer; + assertEquals(2, buffer.size()); + }); + } + + @Test + public void testWrappedException() + { + doWithVTable(100, table -> + { + // register before treating exception to avoid pre-initialisation buffer + VirtualKeyspaceRegistry.instance.register(new VirtualKeyspace(KS_NAME, ImmutableList.of(table))); + ExceptionsTable.INSTANCE = getVirtualTable(ExceptionsTable.class, KS_NAME, EXCEPTIONS_TABLE_NAME); + + MyUncaughtException2 inner = new MyUncaughtException2("inner"); + MyUncaughtException myUncaughtException = new MyUncaughtException("outer", inner); + + JVMStabilityInspector.uncaughtException(currentThread(), myUncaughtException); + + assertTrue(ExceptionsTable.preInitialisationBuffer.isEmpty()); + ExceptionsTable.BoundedMap buffer = table.buffer; + assertEquals(1, buffer.size()); + + LinkedHashMap<String, ExceptionsTable.ExceptionRow> entry = buffer.get(MyUncaughtException2.class.getName()); + assertNotNull(entry); + ExceptionsTable.ExceptionRow exceptionRow = entry.get(inner.getStackTrace()[0].toString()); + assertNotNull(exceptionRow); + assertEquals("inner", exceptionRow.message); + assertEquals(1, exceptionRow.count); + }); + } + + @Test + public void testDeduplication() + { + doWithVTable(100, table -> + { + // register before treating exception to avoid pre-initialisation buffer + VirtualKeyspaceRegistry.instance.register(new VirtualKeyspace(KS_NAME, ImmutableList.of(table))); + ExceptionsTable.INSTANCE = getVirtualTable(ExceptionsTable.class, KS_NAME, EXCEPTIONS_TABLE_NAME); + + // same type of exception + + MyUncaughtException exception1 = new MyUncaughtException("my exception"); + MyUncaughtException exception2 = new MyUncaughtException("my exception"); + MyUncaughtException2 exception3 = new MyUncaughtException2("my second uncaught exception"); + + String firstLocation = ExceptionsTable.ExceptionRow.extractStacktrace(exception1.getStackTrace()).get(0); + String secondLocation = ExceptionsTable.ExceptionRow.extractStacktrace(exception2.getStackTrace()).get(0); + String thirdLocation = ExceptionsTable.ExceptionRow.extractStacktrace(exception3.getStackTrace()).get(0); + + JVMStabilityInspector.uncaughtException(currentThread(), exception1); + JVMStabilityInspector.uncaughtException(currentThread(), exception1); + JVMStabilityInspector.uncaughtException(currentThread(), exception2); + JVMStabilityInspector.uncaughtException(currentThread(), exception3); + + ExceptionsTable.BoundedMap buffer = table.buffer; + assertEquals(2, buffer.size()); + + LinkedHashMap<String, ExceptionsTable.ExceptionRow> exceptionRow = buffer.get(MyUncaughtException.class.getName()); + assertNotNull(exceptionRow); + ExceptionsTable.ExceptionRow firstLocationRow = exceptionRow.get(firstLocation); + assertEquals("my exception", firstLocationRow.message); + assertEquals(2, firstLocationRow.count); + + ExceptionsTable.ExceptionRow secondLocationRow = exceptionRow.get(secondLocation); + assertEquals("my exception", secondLocationRow.message); + assertEquals(1, secondLocationRow.count); + + LinkedHashMap<String, ExceptionsTable.ExceptionRow> exceptionRow2 = buffer.get(MyUncaughtException2.class.getName()); + + assertNotNull(exceptionRow2); + ExceptionsTable.ExceptionRow firstLocationRow2 = exceptionRow2.get(thirdLocation); + assertEquals("my second uncaught exception", firstLocationRow2.message); + assertEquals(1, firstLocationRow2.count); + + List<UntypedResultSet.Row> rows = execute(format("SELECT * FROM %s.%s", KS_NAME, EXCEPTIONS_TABLE_NAME)).stream().collect(toList()); + assertEquals(3, rows.size()); + + List<String> lastStacktraceException1 = rows.get(0).getList(ExceptionsTable.LAST_STACKTRACE_COLUMN_NAME, UTF8Type.instance); + List<String> lastStacktraceException2 = rows.get(1).getList(ExceptionsTable.LAST_STACKTRACE_COLUMN_NAME, UTF8Type.instance); + + assertTrue(lastStacktraceException1.get(0).contains(ExceptionsTableTest.class.getName())); + assertTrue(lastStacktraceException2.get(0).contains(ExceptionsTableTest.class.getName())); + }); + } + + @Test + public void testRemovalOfEntryWithOldestOccurence() + { + doWithVTable(4, table -> + { + // register before treating exception to avoid pre-initialisation buffer + VirtualKeyspaceRegistry.instance.register(new VirtualKeyspace(KS_NAME, ImmutableList.of(table))); + ExceptionsTable.INSTANCE = getVirtualTable(ExceptionsTable.class, KS_NAME, EXCEPTIONS_TABLE_NAME); + + MyUncaughtException2 myException2 = new MyUncaughtException2("my exception2"); + + JVMStabilityInspector.uncaughtException(currentThread(), new MyUncaughtException("my exception")); + Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS); + JVMStabilityInspector.uncaughtException(currentThread(), myException2); + JVMStabilityInspector.uncaughtException(currentThread(), myException2); + + JVMStabilityInspector.uncaughtException(currentThread(), new RuntimeException("some exception")); + JVMStabilityInspector.uncaughtException(currentThread(), new IllegalStateException("some illegal state exception")); + + // we inserted 5th unique exception, so the oldest one, based on the occurence, will be removed + // the first one inserted was MyUncaughtException with "my exception" message so that one will not be there anymore + JVMStabilityInspector.uncaughtException(currentThread(), new IllegalArgumentException("some illegal state exception")); + + assertEquals(4, table.buffer.size()); + assertNull(table.buffer.get(MyUncaughtException.class.getName())); + assertEquals(4, execute(format("SELECT * FROM %s.%s", KS_NAME, EXCEPTIONS_TABLE_NAME)).stream().count()); + + JVMStabilityInspector.uncaughtException(currentThread(), new IllegalArgumentException("some illegal state exception")); + + assertEquals(4, execute(format("SELECT * FROM %s.%s", KS_NAME, EXCEPTIONS_TABLE_NAME)).stream().count()); + assertNull(table.buffer.get(MyUncaughtException2.class.getName())); + }); + } + + @Test + public void testSelection() + { + doWithVTable(4, table -> + { + // register before treating exception to avoid pre-initialisation buffer + VirtualKeyspaceRegistry.instance.register(new VirtualKeyspace(KS_NAME, ImmutableList.of(table))); + ExceptionsTable.INSTANCE = getVirtualTable(ExceptionsTable.class, KS_NAME, EXCEPTIONS_TABLE_NAME); + + MyUncaughtException myUncaughtException = new MyUncaughtException("my exception"); + + JVMStabilityInspector.uncaughtException(currentThread(), myUncaughtException); + + assertFalse(execute(format("SELECT * FROM %s.%s WHERE exception_class = '%s'", Review Comment: maybe matchers are better here, they are more readable and print more clear error messages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
