pron commented on PR #3696: URL: https://github.com/apache/cassandra/pull/3696#issuecomment-3350385957
`--add-opens`/`--add-exports` flags are `FIXME` markers signifying non-portable code that may break with any release. The more there are, the likelier the code is to break. By all accounts, a program with 30 such flags shouldn't work at all unless it's specifically hand-crafted for that release. Even if these changes are necessary yet the software miraculously works across versions, it can't work for long. But this project works on JDK 17, so that this change works on 21 tells me these flags are largely unnecessary or that the fixes they require aren't so complicated. Without such flags, a piece of software is highly likely to work, unchanged, on future JDK releases for a long time, enjoying performance and observability improvements for free. But every single one of them that is removed can contribute to the project's stability and portability, so I would recommend taking the time to make sure they're really needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
