yifan-c commented on code in PR #4399: URL: https://github.com/apache/cassandra/pull/4399#discussion_r2415157643
########## src/java/org/apache/cassandra/db/compression/ICompressionDictionaryCache.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.compression; + +import javax.annotation.Nullable; + +/** + * Interface for managing compression dictionary caching and current dictionary state. + * <p> + * Implementations handle: + * - Local caching of compression dictionaries with automatic cleanup + * - Managing the current active dictionary for write operations + * - Thread-safe access to cached dictionaries + */ +public interface ICompressionDictionaryCache extends AutoCloseable +{ + /** + * Gets the current active compression dictionary. + * + * @return the current compression dictionary, or null if no dictionary is available + */ + @Nullable + CompressionDictionary getCurrent(); Review Comment: Not a huge fan of `Optional`. Null exists anyway, and the callsite would see null in certain cases anyway. If the language can fully eliminate null, then `Optional` makes sense. ``` CompressionDictionary compressionDictionary = compressionDictionaryManager == null ? null : compressionDictionaryManager.getCurrent(); ``` ########## src/java/org/apache/cassandra/db/compression/ICompressionDictionaryCache.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.compression; + +import javax.annotation.Nullable; + +/** + * Interface for managing compression dictionary caching and current dictionary state. + * <p> + * Implementations handle: + * - Local caching of compression dictionaries with automatic cleanup + * - Managing the current active dictionary for write operations + * - Thread-safe access to cached dictionaries + */ +public interface ICompressionDictionaryCache extends AutoCloseable +{ + /** + * Gets the current active compression dictionary. + * + * @return the current compression dictionary, or null if no dictionary is available + */ + @Nullable + CompressionDictionary getCurrent(); Review Comment: Not a huge fan of `Optional`. Null exists anyway, and the callsite would see null in certain cases. If the language can fully eliminate null, then `Optional` makes sense. ``` CompressionDictionary compressionDictionary = compressionDictionaryManager == null ? null : compressionDictionaryManager.getCurrent(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
