smiklosovic commented on code in PR #4399: URL: https://github.com/apache/cassandra/pull/4399#discussion_r2410718577
########## src/java/org/apache/cassandra/io/compress/IDictionaryCompressor.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.io.compress; + +import org.apache.cassandra.db.compression.CompressionDictionary; + +/** + * Interface for compressors that support dictionary-based compression. + * <br> + * Dictionary compressors can use pre-trained compression dictionaries to achieve + * better compression ratios, especially for small data chunks that are similar + * to the training data used to create the dictionary. + * + * @param <T> the specific type of compression dictionary this compressor supports + */ +public interface IDictionaryCompressor<T extends CompressionDictionary> Review Comment: interesting, should not be `IDictionaryCompressor` extending `ICompressor`? Because in `CompressionParams` there is private final ICompressor sstableCompressor; and public boolean isDictionaryCompressionEnabled() { return isEnabled() && sstableCompressor instanceof IDictionaryCompressor; } Which is a little bit confusing to me. I think that `IDictionaryCompressor` extending `ICompressor` is way more conceptually logical. ########## src/java/org/apache/cassandra/io/compress/IDictionaryCompressor.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.io.compress; + +import org.apache.cassandra.db.compression.CompressionDictionary; + +/** + * Interface for compressors that support dictionary-based compression. + * <br> + * Dictionary compressors can use pre-trained compression dictionaries to achieve + * better compression ratios, especially for small data chunks that are similar + * to the training data used to create the dictionary. + * + * @param <T> the specific type of compression dictionary this compressor supports + */ +public interface IDictionaryCompressor<T extends CompressionDictionary> Review Comment: https://github.com/apache/cassandra/pull/4399/files#r2410732332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
