shalnisundram commented on code in PR #4408:
URL: https://github.com/apache/cassandra/pull/4408#discussion_r2409061846
##########
pylib/cqlshlib/test/test_cqlsh_completion.py:
##########
@@ -1205,18 +1211,45 @@ def test_complete_in_alter_role(self):
self.trycompletions('ALTER ROLE foo WITH ACCESS TO ', choices=['ALL',
'DATACENTERS'])
self.trycompletions('ALTER ROLE foo WITH ACCESS FROM ',
choices=['ALL', 'CIDRS'])
- def test_complete_in_create_user(self):
- self.trycompletions('CREATE USER ', choices=['<username>', 'IF'])
- self.trycompletions('CREATE USER IF ', immediate='NOT EXISTS ')
def test_complete_in_drop_role(self):
self.trycompletions('DROP ROLE ', choices=['<identifier>', 'IF',
'<quotedName>'])
+
+ # IDENTITY checks
+ def test_complete_in_add_identity(self):
+ self.trycompletions('ADD ID', immediate='ENTITY ')
+ self.trycompletions('ADD IDENTITY IF ', immediate='NOT EXISTS ')
+ self.trycompletions('ADD IDENTITY IF NOT ', immediate='EXISTS ')
+ self.trycompletions('ADD IDENTITY ',
+ choices=['<pgStringLiteral>', '<quotedStringLiteral>', 'IF'])
+ self.trycompletions("ADD IDENTITY '[email protected]' TO R",
immediate='OLE ')
Review Comment:
done - see change at
https://github.com/apache/cassandra/blob/2d4f243e5018a61175a767855b92a66026335566/pylib/cqlshlib/test/test_cqlsh_completion.py#L1228
Let me know if IDENTITY should be changed to another `urn` example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
