smiklosovic commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2454608575
##########
src/java/org/apache/cassandra/schema/Types.java:
##########
@@ -54,6 +56,10 @@ public final class Types implements Iterable<UserType>
public static final Serializer serializer = new Serializer();
private static final Types NONE = new Types(ImmutableMap.of());
+ private static final String EMPTY_COMMENT = "";
+ private static final String EMPTY_SECURITY_LABEL = "";
+ private static final List<String> EMPTY_FIELD_COMMENTS = new ArrayList<>();
Review Comment:
@jyothsnakonisa it is better if you use `List.of()`. That one will be
unmodifiable instead of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
