smiklosovic commented on code in PR #4427:
URL: https://github.com/apache/cassandra/pull/4427#discussion_r2474322989
##########
src/java/org/apache/cassandra/auth/CassandraRoleManager.java:
##########
@@ -164,12 +168,9 @@ public CassandraRoleManager()
public CassandraRoleManager(Map<String, String> parameters)
{
- supportedOptions = DatabaseDescriptor.getAuthenticator() instanceof
PasswordAuthenticator
Review Comment:
can you please rebase this patch on top of current trunk? This constructor
was changed in CEP-55 by conditionally adding `Option.OPTIONS` among
supportedOptions if there is some specific role name generator.
I think what should happen here is that `getSupportedRoleOptions` should
return Set.of(Option.OPTIONS) but only in case
`Guardrails.roleNamePolicy.getGenerator() != NoOpGenerator.INSTANCE` as is
currently done in trunk.
Basically, my point is that this decision logic should be delegated to
IAuthenticator implementation as you introduced that capability instead having
it baked in here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
