smiklosovic commented on code in PR #4457:
URL: https://github.com/apache/cassandra/pull/4457#discussion_r2486484738
##########
src/java/org/apache/cassandra/io/sstable/AbstractSSTableSimpleWriter.java:
##########
@@ -114,6 +124,20 @@ protected SSTableTxnWriter createWriter(SSTable.Owner
owner) throws IOException
if (makeRangeAware)
return SSTableTxnWriter.createRangeAware(metadata, 0,
ActiveRepairService.UNREPAIRED_SSTABLE, ActiveRepairService.NO_PENDING_REPAIR,
false, format, header);
+
+ SSTable.Owner useOwner;
+
+ if (this.owner != null && this.owner.compressionDictionaryManager() !=
null && compressionDictionary != null)
+ {
+ // already checks if it is cached or not
+
this.owner.compressionDictionaryManager().add(compressionDictionary);
+ useOwner = this.owner;
+ }
+ else
+ {
+ useOwner = owner;
Review Comment:
I added constructors accepting SSTable.Owner in both writers as suggested
above. I would still keep this logic as is for integrations using this
differently so it would be still compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
