smiklosovic commented on code in PR #4458:
URL: https://github.com/apache/cassandra/pull/4458#discussion_r2490171694


##########
src/java/org/apache/cassandra/db/compression/CompressionDictionary.java:
##########
@@ -281,4 +315,60 @@ public String toString()
                    '}';
         }
     }
+
+    /**
+     * The purpose of lightweight dictionary is to not carry the actual 
dictionary bytes for performance reasons.
+     * Handy for situations when retrieval from the database does not need to 
contain dictionary
+     * or the instatiation of a proper dictionary object is not desirable or 
unnecessary for other,
+     * mostly performance-related, reasons.
+     */
+    class LightweightCompressionDictionary implements CompressionDictionary

Review Comment:
   But you are probably right, I think returning something simple is probably 
better. I will try to model that in followup commits. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to