yifan-c commented on code in PR #4459:
URL: https://github.com/apache/cassandra/pull/4459#discussion_r2491773315
##########
src/java/org/apache/cassandra/db/compression/CompressionDictionary.java:
##########
@@ -49,6 +49,14 @@ public interface CompressionDictionary extends AutoCloseable
*/
byte[] rawDictionary();
+ /**
+ * Get memory occupied of this dictionary as a whole.
+ * Use for metrics exposing used memory in total.
+ *
+ * @return memory occuppied by this compression dictionary
+ */
+ int occupiedMemory();
Review Comment:
Looking at the method the next day... now I lean more towards adding `bytes`
to the name. Maybe also add an explanation on return `int`, since we expect the
dictionary size should be in KiBs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
