jmckenzie-dev commented on code in PR #3696:
URL: https://github.com/apache/cassandra/pull/3696#discussion_r2733702276
##########
src/java/org/apache/cassandra/service/GCInspector.java:
##########
@@ -357,18 +405,63 @@ public void setGcLogThresholdInMs(long threshold)
if (gcWarnThresholdInMs != 0 && threshold > gcWarnThresholdInMs)
throw new IllegalArgumentException("Threshold must be less than
gcWarnThresholdInMs which is currently "
+ gcWarnThresholdInMs);
-
- DatabaseDescriptor.setGCLogThreshold((int) threshold);
+ DatabaseDescriptor.setZGCLogThreshold(threshold);
+ DatabaseDescriptor.setGCLogThreshold(threshold);
}
+ @Override
public long getGcLogThresholdInMs()
{
- return DatabaseDescriptor.getGCLogThreshold();
+ return hasZGC ? DatabaseDescriptor.getZGCLogThreshold() :
DatabaseDescriptor.getGCLogThreshold();
}
+ @Override
public long getStatusThresholdInMs()
{
return getGcWarnThresholdInMs() != 0 ? getGcWarnThresholdInMs() :
getGcLogThresholdInMs();
}
+ @Override
+ public void setGcPauseLogThresholdInMs(long threshold)
+ {
+ if (threshold <= 0)
Review Comment:
All methods now call `validateGCParams` correctly in `DatabaseDescriptor`
and check for a variety of OOB conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
