dcapwell commented on code in PR #4561:
URL: https://github.com/apache/cassandra/pull/4561#discussion_r2748425697
##########
src/java/org/apache/cassandra/index/sai/utils/IndexTermType.java:
##########
@@ -453,6 +459,70 @@ public Iterator<ByteBuffer> valuesOf(Row row, long
nowInSecs)
}
}
+ public Iterator<ByteBuffer> valuesOfFrozenCollection (Row row, long
nowInSecs)
+ {
+ Cell<?> cell = row.getCell(columnMetadata);
Review Comment:
`public ByteBuffer valueOf(DecoratedKey key, Row row, long nowInSecs)` does
the following check
```
if (row == null)
return null;
```
Yet this doesn't have such a null check? I can't tell if thats just being
extra defensive or its needed, but for safety can you add it as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
