belliottsmith commented on code in PR #4562:
URL: https://github.com/apache/cassandra/pull/4562#discussion_r2773971081
##########
src/java/org/apache/cassandra/service/accord/AccordCache.java:
##########
@@ -1176,7 +1178,7 @@ public Shrink decideFullShrink(RoutingKey key,
CommandsForKey value)
if (value.isEmpty() || value.isLoadingPruned())
return Shrink.EVICT;
- if (value.size() < 64)
+ if (SHRINK_WITHOUT_LOCK <= 0 || value.size() < SHRINK_WITHOUT_LOCK)
Review Comment:
I think it is fine either way, though we should be consistent. Since
`value.size() >= 0`, `value.size() < SHRINK_WITHOUT_LOCK` cannot be true unless
`SHRINK_WITHOUT_LOCK > 0`. I should match both versions of this to the same
basic logic though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
