minal-kyada commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2780455382
##########
src/java/org/apache/cassandra/service/WriteResponseHandler.java:
##########
@@ -58,6 +61,12 @@ public WriteResponseHandler(ReplicaPlan.ForWrite
replicaPlan, WriteType writeTyp
public void onResponse(Message<T> m)
{
+ if (m != null)
Review Comment:
I doubt, mainly due to 3 reasons:
1. For local writes, warning context is already updated before onResponse is
called in `StorageProxy`
2. By the time `onResponse(null)` is called, the params have already been
captured
3. We can't capture params again in onResponse because `MessageParams` will
be reset in the finally block
thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
