iamaleksey commented on code in PR #4447:
URL: https://github.com/apache/cassandra/pull/4447#discussion_r2804822339
##########
src/java/org/apache/cassandra/service/paxos/CasForwardRequest.java:
##########
@@ -108,10 +105,36 @@ public long serializedSize(CasForwardRequest
forwardRequest, int version)
size += 1; // consistencyForPaxos.code
size += 1; // consistencyForCommit.code
size += TypeSizes.sizeofUnsignedVInt(forwardRequest.nowInSeconds);
- size +=
RemoteClientState.serializer.serializedSize(forwardRequest.clientState,
version);
+ size += serializedSizeClientState(forwardRequest.clientState);
size +=
CQL3CasRequest.serializer.serializedSize(forwardRequest.casRequest, version);
-
return size;
}
+
+ private static final int IS_SUPER = 0x01;
Review Comment:
I can put it anywhere really. The reason I didn't put it in `ClientState` is
that it doesn't fully serialize entire `ClientState` - just a minimal
representation that's needed for guardrail processing, and only by
`CasForwardRequest`. I felt like moving it to `ClientState` might be a little
misleading and cause someone to trip over it in the future if they aren't
careful enough. But I think I don't mind either way - feel free to move it
there, or let me know if you want me to move it to `ClientState` still - and I
will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
