yifan-c commented on code in PR #320:
URL: https://github.com/apache/cassandra-sidecar/pull/320#discussion_r2815172924
##########
server/build.gradle:
##########
@@ -202,7 +202,12 @@ dependencies {
// Needed for snapshot manifest validation
integrationTestImplementation(group: 'com.fasterxml.jackson.datatype',
name: 'jackson-datatype-jsr310', version: "${project.jacksonVersion}")
-
containerTestImplementation('com.adobe.testing:s3mock-testcontainers:2.17.0')
// 3.x version do not support java 11
+
containerTestImplementation('com.adobe.testing:s3mock-testcontainers:2.17.0') {
// 3.x version do not support java 11
+ // Exclude old testcontainers to force upgrade to 1.21.4 which
supports Docker API 1.44+
+ exclude group: 'org.testcontainers'
+ }
+ containerTestImplementation 'org.testcontainers:testcontainers:1.21.4'
Review Comment:
True. I actually had the comment there that we cannot use 3.x version due to
jdk version support. 🤦♂️
Can you update the comment to explain why supporting Dock API 1.44+ is
required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
