Mmuzaf commented on code in PR #4626:
URL: https://github.com/apache/cassandra/pull/4626#discussion_r2827229087
##########
test/unit/org/apache/cassandra/tools/nodetool/mock/SjkMockTest.java:
##########
@@ -48,9 +48,38 @@ public void testSjkHelp()
@Test
public void testSjkTtop()
{
- ToolRunner.ToolResult result = invokeNodetool("sjk", "hh",
"--top-number", "10", "--live");
+ ToolRunner.ToolResult result = invokeNodetool("sjk", "hh",
"--top-number", "10000", "--live");
Review Comment:
This test is flaky because the class we are looking for sometimes does not
appear in the command output due to the result limit. A possible solution is
either to make the regex more generic or to display all classes. The latter
option seems more readable and clearer for validating test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
