SiyaoIsHiding commented on code in PR #2045:
URL:
https://github.com/apache/cassandra-java-driver/pull/2045#discussion_r2888202644
##########
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/PreparedStatementCachingIT.java:
##########
@@ -295,17 +298,20 @@ private void invalidationTestInner(
Consumer<CqlSession> setupCacheEntryTestBasic =
(session) -> {
- session.execute("CREATE TYPE test_type_1 (a text, b int)");
- session.execute("CREATE TYPE test_type_2 (c int, d text)");
- session.execute("CREATE TABLE test_table_1 (e int primary key, f
frozen<test_type_1>)");
- session.execute("CREATE TABLE test_table_2 (g int primary key, h
frozen<test_type_2>)");
+ session.execute("CREATE TYPE test_type_caching_1 (a text, b int)");
+ session.execute("CREATE TYPE test_type_caching_2 (c int, d text)");
+ session.execute(
+ "CREATE TABLE test_table_caching_1 (e int primary key, f
frozen<test_type_caching_1>)");
+ session.execute(
+ "CREATE TABLE test_table_caching_2 (g int primary key, h
frozen<test_type_caching_2>)");
Review Comment:
`invalidationResultSetTest`, `invalidationVariableDefsTest`, and
`invalidationTestInner` are shared among basic/collection/tuple/nested. They
need to be refactored if we want to change the table names to specify
basic/collection/tuple/nested. I don't think it's worth it, cuz test methods
inside of one test suite won't run in parallel anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
