maedhroz commented on code in PR #4652:
URL: https://github.com/apache/cassandra/pull/4652#discussion_r2926447307
##########
src/java/org/apache/cassandra/locator/ReplicationFactor.java:
##########
@@ -65,8 +65,8 @@ static void validate(int totalRF, int transientRF)
"Transient replication is not enabled on
this node");
Preconditions.checkArgument(totalRF >= 0,
"Replication factor must be non-negative,
found %s", totalRF);
- Preconditions.checkArgument(transientRF == 0 || transientRF < totalRF,
- "Transient replicas must be zero, or less
than total replication factor. For %s/%s", totalRF, transientRF);
+ Preconditions.checkArgument(transientRF <= totalRF,
+ "Transient replicas must be less than or
equal to total replication factor. For %s/%s", totalRF, transientRF);
Review Comment:
This is okay now, because a satellite DC is only witnesses? Does this
conflict with the new check for non-zero `fullReplicas` above in `ARS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
