absurdfarce commented on code in PR #583:
URL:
https://github.com/apache/cassandra-cpp-driver/pull/583#discussion_r2926984277
##########
src/prepare_host_handler.cpp:
##########
@@ -69,8 +69,6 @@ void PrepareHostHandler::prepare(uv_loop_t* loop, const
ConnectionSettings& sett
}
void PrepareHostHandler::on_close(Connection* connection) {
- callback_(this);
Review Comment:
Long-term the better answer is probably to not make
HOST_UP/HOST_READY/HOST_ADD event distribution a function of the callback in
use here. Those ops should be handled by logic in the relevant functions of
cluster.cpp, specifically as some kind of "after" action from the prepare op.
But this fix allows us to address the immediate problem without having to
refactor the entirety of message delivery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
