tolbertam commented on code in PR #4558:
URL: https://github.com/apache/cassandra/pull/4558#discussion_r2978448916
##########
.build/run-tests.sh:
##########
@@ -188,21 +188,23 @@ _build_all_dtest_jars() {
if [ -d ${TMP_DIR}/cassandra-dtest-jars/.git ] && [
"https://github.com/apache/cassandra.git"; == "$(git -C
${TMP_DIR}/cassandra-dtest-jars remote get-url origin)" ] ; then
echo "Reusing ${TMP_DIR}/cassandra-dtest-jars for past branch dtest jars"
if [ "x" == "x${OFFLINE}" ] ; then
- until git -C ${TMP_DIR}/cassandra-dtest-jars fetch --quiet origin ; do
echo "git -C ${TMP_DIR}/cassandra-dtest-jars fetch failed… trying again… " ;
done
+ until git -C ${TMP_DIR}/cassandra-dtest-jars fetch --quiet --tags
origin ; do echo "git -C ${TMP_DIR}/cassandra-dtest-jars fetch failed… trying
again… " ; done
fi
else
echo "Cloning cassandra to ${TMP_DIR}/cassandra-dtest-jars for past
branch dtest jars"
rm -fR ${TMP_DIR}/cassandra-dtest-jars
pushd $TMP_DIR >/dev/null
- until git clone --quiet --depth 1 --no-single-branch
https://github.com/apache/cassandra.git cassandra-dtest-jars ; do echo "git
clone failed… trying again… " ; done
+ until git clone --quiet --depth 1 --no-single-branch --tags
https://github.com/apache/cassandra.git cassandra-dtest-jars ; do echo "git
clone failed… trying again… " ; done
popd >/dev/null
fi
# cassandra-4 branches need CASSANDRA_USE_JDK11 to allow jdk11
[ "${java_version}" -eq 11 ] && export CASSANDRA_USE_JDK11=true
pushd ${TMP_DIR}/cassandra-dtest-jars >/dev/null
- for branch in cassandra-4.0 cassandra-4.1 cassandra-5.0 ; do
+ # Note: cassandra-5.0.6 tag is used instead of cassandra-5.0 branch to
enable
+ # testing upgrades from 5.0.6 to the current local build for autorepair
feature
+ for branch in cassandra-4.0 cassandra-4.1 cassandra-5.0.6 ; do
Review Comment:
nit: can we change this to cassandra-5.0.7 now?
##########
.build/run-tests.sh:
##########
@@ -188,21 +188,23 @@ _build_all_dtest_jars() {
if [ -d ${TMP_DIR}/cassandra-dtest-jars/.git ] && [
"https://github.com/apache/cassandra.git"; == "$(git -C
${TMP_DIR}/cassandra-dtest-jars remote get-url origin)" ] ; then
echo "Reusing ${TMP_DIR}/cassandra-dtest-jars for past branch dtest jars"
if [ "x" == "x${OFFLINE}" ] ; then
- until git -C ${TMP_DIR}/cassandra-dtest-jars fetch --quiet origin ; do
echo "git -C ${TMP_DIR}/cassandra-dtest-jars fetch failed… trying again… " ;
done
+ until git -C ${TMP_DIR}/cassandra-dtest-jars fetch --quiet --tags
origin ; do echo "git -C ${TMP_DIR}/cassandra-dtest-jars fetch failed… trying
again… " ; done
fi
else
echo "Cloning cassandra to ${TMP_DIR}/cassandra-dtest-jars for past
branch dtest jars"
rm -fR ${TMP_DIR}/cassandra-dtest-jars
pushd $TMP_DIR >/dev/null
- until git clone --quiet --depth 1 --no-single-branch
https://github.com/apache/cassandra.git cassandra-dtest-jars ; do echo "git
clone failed… trying again… " ; done
+ until git clone --quiet --depth 1 --no-single-branch --tags
https://github.com/apache/cassandra.git cassandra-dtest-jars ; do echo "git
clone failed… trying again… " ; done
popd >/dev/null
fi
# cassandra-4 branches need CASSANDRA_USE_JDK11 to allow jdk11
[ "${java_version}" -eq 11 ] && export CASSANDRA_USE_JDK11=true
pushd ${TMP_DIR}/cassandra-dtest-jars >/dev/null
- for branch in cassandra-4.0 cassandra-4.1 cassandra-5.0 ; do
+ # Note: cassandra-5.0.6 tag is used instead of cassandra-5.0 branch to
enable
+ # testing upgrades from 5.0.6 to the current local build for autorepair
feature
+ for branch in cassandra-4.0 cassandra-4.1 cassandra-5.0.6 ; do
Review Comment:
nit: can we change this to `cassandra-5.0.7` now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
