burmanm commented on code in PR #318:
URL: https://github.com/apache/cassandra-sidecar/pull/318#discussion_r3002649249
##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/CQLSessionProviderImpl.java:
##########
@@ -119,8 +122,10 @@ public CQLSessionProviderImpl(List<InetSocketAddress>
contactPoints,
this.localInstances = localInstances;
this.localDc = localDc;
this.numAdditionalConnections = numAdditionalConnections;
- this.username = username;
- this.password = password;
+ Map<String, String> namedParameters = new HashMap<>();
+ namedParameters.put("username", username);
+ namedParameters.put("password", password);
Review Comment:
This would cause NPE if the username/password is null, which is acceptable
(and something the tests do). Map.of requires non-null for all values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
