absurdfarce commented on code in PR #2063:
URL:
https://github.com/apache/cassandra-java-driver/pull/2063#discussion_r3018985909
##########
pom.xml:
##########
@@ -882,7 +899,49 @@ limitations under the License.]]></inlineHeader>
<useStandardDocletOptions>false</useStandardDocletOptions>
</configuration>
</execution>
+ <execution>
+ <!-- Generate aggregated Javadoc for specified modules -->
+ <id>aggregate-javadoc</id>
+ <goals>
+ <goal>aggregate</goal>
+ </goals>
+ <phase>site</phase>
+ <configuration>
+ <includeDependencySources>false</includeDependencySources>
+ <dependencySourceIncludes>
+
<dependencySourceInclude>org.apache.cassandra:java-driver-core</dependencySourceInclude>
+
<dependencySourceInclude>org.apache.cassandra:java-driver-query-builder</dependencySourceInclude>
+
<dependencySourceInclude>org.apache.cassandra:java-driver-mapper-runtime</dependencySourceInclude>
+ </dependencySourceIncludes>
+ <reactorProjects>
+ <reactorProject>core</reactorProject>
+ <reactorProject>query-builder</reactorProject>
+ <reactorProject>mapper-runtime</reactorProject>
+ </reactorProjects>
+ <doctitle>Apache Cassandra Java Driver ${project.version}
API</doctitle>
+ <bottom><![CDATA[
+ Copyright © {inceptionYear}–{currentYear} <a
href="https://www.apache.org/";>The Apache Software Foundation</a>. All rights
reserved.
+ ]]></bottom>
+ </configuration>
+ </execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_annotations</artifactId>
+ <version>2.3.4</version>
+ </dependency>
+ <dependency>
+ <groupId>com.github.stephenc.jcip</groupId>
+ <artifactId>jcip-annotations</artifactId>
+ <version>1.0-1</version>
+ </dependency>
+ <dependency>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-annotations</artifactId>
Review Comment:
Ah, okay, I did find it. I was thinking of some work done for dsbulk,
specifically the omnibus version updates. [This
comment](https://github.com/datastax/dsbulk/pull/515#discussion_r2612976976)
provides the relevant context; they were removed in the transition of the Java
driver to the ASF, I believe because of some licensing concerns. The relevant
change is
[here](https://github.com/apache/cassandra-java-driver/commit/1991537d50b9100a3d25cd669af2a892409c1c95),
controlling ticket is
[CASSJAVA-34](https://issues.apache.org/jira/browse/CASSJAVA-34).
As mentioned above the dependencies are still in pom.xml and are marked as
"provided" everywhere due to the changes in CASSJAVA-34. That's why I had to
include them manually in dsbulk when we upgraded to the new driver.
Can you elaborate more on why you need them in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
