Aklakan commented on code in PR #1689:
URL: https://github.com/apache/jena/pull/1689#discussion_r1053236048


##########
jena-extras/jena-serviceenhancer/src/main/java/org/apache/jena/sparql/service/enhancer/impl/OpServiceInfo.java:
##########
@@ -93,7 +93,7 @@ public OpServiceInfo(OpService opService) {
 
         // Handling of a null supOp - can that happen?
         Set<Var> visibleSubOpVars = OpVars.visibleVars(baseSubOp);
-        this.visibleSubOpVarsScopedToNorm = 
VarScopeUtils.normalizeVarScopesGlobal(visibleSubOpVars);

Review Comment:
   This one-liner fixes a scoping issue @LorenzBuehmann found just after he 
reported that this PR works while trying variants of the query that led to this 
PR. Instead of cut-off results it may lead to missing columns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to