kinow commented on PR #1684:
URL: https://github.com/apache/jena/pull/1684#issuecomment-1364574405
Hi @SimonBin I was going to push to your branch to amend the commit message
and add the e2e test, but git said "ERROR: Permission to AKSW/jena.git denied
to kinow.". I think you didn't select the option to allow contributors of the
project to edit your PR/branch.
Here's the diff for the test. It was fun, I hadn't written a test that
required resizing an element yet :slightly_smiling_face:
```diff
diff --git a/jena-fuseki2/jena-fuseki-ui/tests/e2e/specs/query.cy.js
b/jena-fuseki2/jena-fuseki-ui/tests/e2e/specs/query.cy.js
index 0e90435a0c..f8a55e4518 100644
--- a/jena-fuseki2/jena-fuseki-ui/tests/e2e/specs/query.cy.js
+++ b/jena-fuseki2/jena-fuseki-ui/tests/e2e/specs/query.cy.js
@@ -76,4 +76,31 @@ describe('Query', () => {
.its('response')
.should('have.property', 'statusCode', 203)
})
+ it('Can resize the query editor', () => {
+ cy.visit('/#/dataset/skosmos/query')
+ cy
+ .get('div.CodeMirror')
+ .should('be.visible')
+ .invoke('css', 'height')
+ .as('beforeHeight')
+ cy
+ .get('div.resizeChip')
+ .should('exist')
+ .trigger('mousedown', {
+ which: 1, force: true
+ })
+ .trigger('mousemove', { which: 1, force: true, x: 0, y: 50 })
+ .trigger('mouseup', {
+ force: true
+ });
+ cy
+ .get('div.CodeMirror')
+ .invoke('css', 'height')
+ .as('afterHeight')
+ cy.get('@beforeHeight').then(beforeHeight => {
+ cy.get('@afterHeight').then(afterHeight => {
+ expect(afterHeight).to.not.equal(beforeHeight)
+ })
+ })
+ })
})
```
Thanks!
@afs tested locally, small change and works fine. Can be merged now or after
4.7.0 :+1:
Thanks @SimonBin !
Bruno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
