kinow commented on code in PR #1679:
URL: https://github.com/apache/jena/pull/1679#discussion_r1148620740
##########
jena-fuseki2/jena-fuseki-ui/src/views/dataset/Edit.vue:
##########
Review Comment:
@SimonBin I had a look at the e2e tests, and was going to write a test for
this change, when I realized it would be easier to move the change to the
`FusekiService` class, wrapping the logic there in case we need to further
modify how these URL's are built. Also reduced a bit the complexity, and moved
this logic away from the view.
That way I just modified one test and got that covered :+1:
Could you please test this branch and check if it works?
Thank you!
##########
jena-fuseki2/jena-fuseki-ui/src/views/dataset/Edit.vue:
##########
Review Comment:
The rest of changes keep being for Cypress. The change for this pull request
is in this file, and in
`jena-fuseki2/jena-fuseki-ui/src/services/fuseki.service.js`.
##########
jena-fuseki2/jena-fuseki-ui/tests/unit/services/fuseki.service.spec.js:
##########
@@ -283,8 +283,11 @@ describe('FusekiService', () => {
stub.resolves(Promise.resolve({
data: 42
}))
- const graph = await fusekiService.fetchGraph('jena', 'default')
+ const graph = await fusekiService.fetchGraph('jena', ['dataEndpoint'],
'default')
expect(stub.called).to.equal(true)
+ const getArgs = stub.getCall(0).args
+ // See https://github.com/apache/jena/pull/1679
+ expect(getArgs[0]).to.equal('/jena/dataEndpoint')
Review Comment:
Changed this test to go through the branch where there is an endpoint when
building the Jena Fuseki URIl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
