rvesse commented on code in PR #2298:
URL: https://github.com/apache/jena/pull/2298#discussion_r1505622316
##########
jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/FusekiServer.java:
##########
@@ -1704,5 +1713,28 @@ private static void applyLocalhost(Server server) {
}
}
}
+
+ private static Map<String,String> parseCORSConfigFile(String filename)
{
+ try {
Review Comment:
Is using a JSON file overkill here? Wondering if we might not be better
just taking in a Java Properties file as then the whole method reduces to:
```java
try (FileInputStream input = new FileInputStream(filename)) {
Properties properties = new Properties();
properties.load(input);
// Convert Properties into Map
return map;
}
```
##########
jena-fuseki2/jena-fuseki-main/testing/Config/cors_config.json:
##########
Review Comment:
Per my other comment this could just be a Java properties file i.e.
```
allowedOrigins=*
allowedMethods=GET,POST,DELETE,PUT,HEAD,OPTIONS,PATH
# etc
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
