TelicentPaul commented on code in PR #2298:
URL: https://github.com/apache/jena/pull/2298#discussion_r1507465037
##########
jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/FusekiServer.java:
##########
@@ -1366,14 +1381,15 @@ private ServletContextHandler
buildFusekiServerContext() {
private static void prepareDataServices(DataAccessPointRegistry
dapRegistry, OperationRegistry operationReg) {
dapRegistry.forEach((name, dap) -> {
// Override for graph-level access control.
- if (
DataAccessCtl.isAccessControlled(dap.getDataService().getDataset()) ) {
- dap.getDataService().forEachEndpoint(ep->
- FusekiLib.modifyForAccessCtl(ep,
DataAccessCtl.requestUserServlet));
+ if
(DataAccessCtl.isAccessControlled(dap.getDataService().getDataset())) {
+ dap.getDataService().forEachEndpoint(ep ->
+
FusekiLib.modifyForAccessCtl(ep,
+
DataAccessCtl.requestUserServlet));
Review Comment:
A side-effect of the rebase. Intellij's formatting seems to have taken real
issue with what was there. I'm going to remove most of those as they're not
tied to the change
##########
jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/FusekiServer.java:
##########
@@ -1383,12 +1399,12 @@ private static void
prepareDataServices(DataAccessPointRegistry dapRegistry, Ope
}
/**
- * Given a ServletContextHandler, set the servlet attributes for
- * {@link DataAccessPointRegistry} and {@link OperationRegistry}.
+ * Given a ServletContextHandler, set the servlet attributes for
{@link DataAccessPointRegistry} and
+ * {@link OperationRegistry}.
*/
private static void applyDatabaseSetup(ServletContextHandler handler,
-
DataAccessPointRegistry dapRegistry,
- OperationRegistry
operationReg) {
+ DataAccessPointRegistry
dapRegistry,
+ OperationRegistry operationReg)
{
Review Comment:
Again, I'll remove it. Better for you to to have a small "fix formatting and
layout" PR outside of this than muddy the waters here.
##########
jena-fuseki2/jena-fuseki-main/testing/Config/cors.properties:
##########
@@ -0,0 +1,5 @@
+allowedOrigins=*
+allowedMethods=GET,POST,DELETE,PUT,HEAD,OPTIONS,PATCH
+allowedHeaders=X-Requested-With, Content-Type, Accept, Origin, Last-Modified,
Authorization, Security-Label
+exposedHeaders=Cache-Control, Content-Language, Content-Length, Content-Type,
Expires, Last-Modified, Pragma
+chainPreflight=false
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
