kinow commented on code in PR #2329:
URL: https://github.com/apache/jena/pull/2329#discussion_r1522111307
##########
jena-geosparql/src/test/java/org/apache/jena/ext/io/github/galbiston/expiring_map/ExpiringMapTest.java:
##########
@@ -441,6 +437,7 @@ public void testExpiry_change_expiry_interval_reduced()
throws InterruptedExcept
*
* @throws java.lang.InterruptedException
*/
+ @Ignore // This test is not stable on loaded CI servers.
Review Comment:
Is it for all CI servers or just Windows?
Maybe we could replace this by `@EnabledIfEnvironmentVariable` instead? We
can have a bunch of tests like this (or fragile/unstable) and enable with
`SOME_VAR=1 mvn test blabla`?
https://junit.org/junit5/docs/5.2.0/api/org/junit/jupiter/api/condition/EnabledIfEnvironmentVariable.html
& https://www.baeldung.com/junit-5-conditional-test-execution
Easier than using test suites or Maven profiles, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
