kinow opened a new pull request, #2373:
URL: https://github.com/apache/jena/pull/2373
GitHub issue resolved #2370
Pull request Description:
@afs, @jmkeil, first stab at #2370. Had a look at [^1] and [^2], and I saw
some parts of the text mentioning "percent-encoded" in requests, and that the
backend is supposed to return 400, as it's doing now. From quickly reading
those two (skipping parts, trying to find info for validation), I think
1. empty is valid
2. spaces are no-no
3. otherwise it must be a URI
4. encoded URL is no-no, it must be a valid URI, without encoded parts
I extended the current validation to also check 3 and 4 now. Does that sound
right?
This is a draft until I confirm that the fix looks good, then I will either
write the tests, or modify the PR again to move the code to some JS module as
that a lot easier to write unit-test against, instead of testing code buried
somewhere in Vue code/components.
Cheers
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena
website](https://github.com/apache/jena-site/)
- [x] Commits have been squashed to remove intermediate development commit
messages.
- [x] Key commit messages start with the issue number (GH-xxxx)
By submitting this pull request, I acknowledge that I am making a
contribution to the Apache Software Foundation under the terms and conditions
of the [Contributor's
Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing"
guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
[^1]:
https://www.w3.org/TR/2013/REC-sparql11-http-rdf-update-20130321/#http-post
[^2]: https://www.ietf.org/rfc/rfc3986.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
