OyvindLGjesdal opened a new pull request, #2410: URL: https://github.com/apache/jena/pull/2410
GitHub issue resolved #2344 Pull request Description: Looked at the links provided by @kinow in https://github.com/apache/jena/issues/2344#issuecomment-2021290428 and tried to change `'` with `\"`. This gave a new error which looks like `crossenv` doesn't support `:=` on windows, in `${FUSEKI_PORT:=3030}` (and PORT). Looked at crossenv on github and I think it is not available. I looked at maybe changing the shell to run from in windows, by adding a .npmrc file, but then I got license (RAT) errors when running the CI, and instead of adding it to exclude list, I asked GPT figured the operator is *probably* not available in powershell. I ended up using the ENV vars only since `FUSEKI_PORT` is already used without fallback values in other locations of the package.json file. Glanced at the e2e output in https://github.com/OyvindLGjesdal/jena/actions/runs/8623049304 and it looks good to my untrained eyes. Have left to check if it breaks anything for Linux and Mac, and will create a single commit. ``` [INFO] $ cross-env FUSEKI_PORT="${FUSEKI_PORT:=3030}" PORT="${PORT:=8080}" concurrently --names 'SERVER,CLIENT,TESTS' --prefix-colors 'yellow,blue,green' --success 'first' --kill-others "yarn run serve:fuseki" "yarn wait-on http://localhost:${FUSEKI_PORT}/$/ping && yarn run dev" "yarn wait-on http-get://localhost:${PORT}/index.html && cypress run $@" [INFO] [TESTS] $ C:\jena\jena-fuseki2\jena-fuseki-ui\node_modules\.bin\wait-on http-get://localhost:${PORT:=8080}/index.html [INFO] [CLIENT] $ C:\jena\jena-fuseki2\jena-fuseki-ui\node_modules\.bin\wait-on http://localhost:${FUSEKI_PORT:=3030}/$/ping [INFO] [SERVER] $ nodemon src/services/mock/json-server.js [INFO] [SERVER] [nodemon] 3.1.0 [INFO] [SERVER] [nodemon] to restart at any time, enter `rs` [INFO] [SERVER] [nodemon] watching path(s): *.* [INFO] [SERVER] [nodemon] watching extensions: js,mjs,cjs,json [INFO] [SERVER] [nodemon] starting `node src/services/mock/json-server.js` [INFO] [SERVER] node:events:496 [INFO] [SERVER] throw er; // Unhandled 'error' event [INFO] [SERVER] ^ [INFO] [SERVER] [INFO] [SERVER] Error: listen EACCES: permission denied ${FUSEKI_PORT:=3030} [INFO] [SERVER] at Server.setupListenHandle [as _listen2] (node:net:1855:21) [INFO] [SERVER] at listenInCluster (node:net:1920:12) [INFO] [SERVER] at Server.listen (node:net:2025:5) [INFO] [SERVER] at Function.listen (C:\jena\jena-fuseki2\jena-fuseki-ui\node_modules\express\lib\application.js:635:24) [INFO] [SERVER] at Object.<anonymous> (C:\jena\jena-fuseki2\jena-fuseki-ui\src\services\mock\json-server.js:294:8) [INFO] [SERVER] at Module._compile (node:internal/modules/cjs/loader:1376:14) [INFO] [SERVER] at Module._extensions..js (node:internal/modules/cjs/loader:1435:10) [INFO] [SERVER] at Module.load (node:internal/modules/cjs/loader:1207:32) [INFO] [SERVER] at Module._load (node:internal/modules/cjs/loader:1023:12) [INFO] [SERVER] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12) [INFO] [SERVER] Emitted 'error' event on Server instance at: [INFO] [SERVER] at emitErrorNT (node:net:1899:8) [INFO] [SERVER] at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { [INFO] [SERVER] code: 'EACCES', [INFO] [SERVER] errno: -4092, [INFO] [SERVER] syscall: 'listen', [INFO] [SERVER] address: '${FUSEKI_PORT:=3030}', [INFO] [SERVER] port: -1 [INFO] [SERVER] } [INFO] [SERVER] [INFO] [SERVER] Node.js v20.11.0 [INFO] [SERVER] [nodemon] app crashed - waiting for file changes before starting... ``` ---- - [ ] Tests are included. - [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/) - [ ] Commits have been squashed to remove intermediate development commit messages. - [ ] Key commit messages start with the issue number (GH-xxxx) By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html). ---- See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
